[ENHANCEMENT] remote-write: increase interval for successful write before resharding #14054
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kushagra Shukla <kushalshukla110@gmail.com>
kushalShukla-web
requested review from
cstyan,
bwplotka and
tomwilkie
as code owners
|
fixes #14044 |
bboreham
changed the title
bboreham
reviewed
May 4, 2024
cstyan
reviewed
May 6, 2024
| @@ -1020,7 +1020,7 @@ func (t *QueueManager) shouldReshard(desiredShards int) bool { | |||
| } | |||
| // We shouldn't reshard if Prometheus hasn't been able to send to the | |||
| // remote endpoint successfully within some period of time. | |||
| minSendTimestamp := time.Now().Add(-2 * time.Duration(t.cfg.BatchSendDeadline)).Unix() | |||
| minSendTimestamp := time.Now().Add(-2*time.Duration(t.cfg.BatchSendDeadline) + shardUpdateDuration).Unix() | |||
There was a problem hiding this comment.
this could potentially even just be time.Now().Add(-1*shardUpdateDuration), if we haven't been able to successfully send since the last time we checked if we should reshard then just skip
|
left a comment on the issue @bboreham curious as to whether you decreased the max batch since in step with the decrease in batch send deadline |
|
guys i will look at this issue/pr again and let you know my thoughts about , currently busy with my exams . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.