doc: clarify rate values are averaged
#14045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: asymmetric <101816+asymmetric@users.noreply.github.com>
|
You don't think "the per-second average rate of increase", a few lines up, already covered it? |
|
For me it wasn't clear enough no, although I guess it could be for others. But if this doesn't decrease clarity for anyone, and only increases it for some, I think it makes sense to merge. |
beorn7
reviewed
May 8, 2024
| @@ -532,7 +532,7 @@ resets due to target restarts) are automatically adjusted for. Also, the | |||
| calculation extrapolates to the ends of the time range, allowing for missed | |||
| scrapes or imperfect alignment of scrape cycles with the range's time period. | |||
|
|
|||
| The following example expression returns the per-second rate of HTTP requests as measured | |||
| The following example expression returns the per-second rate of HTTP requests averaged | |||
There was a problem hiding this comment.
Maybe let's stay as consistent as possible and use the same wording as above, so no misunderstanding is possible that we are talking about the same thing as in the previous paragraph?
Suggested change
| The following example expression returns the per-second rate of HTTP requests averaged | |
| The following example expression returns the per-second average rate of HTTP requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous formulation, it wasn't clear to me what
[5m]was doing, now it should be more clear that it's the window used to calculate the average.