-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pressure collector nil reference #3016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the PSI metrics are returned in order to avoid nil pointer dereference. * Update fixutre to match real-world samples. Fixes: #3015 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
superq/psi_null_check
branch
from
May 14, 2024 07:52
058f817
to
b12ab35
Compare
rexagod
approved these changes
May 14, 2024
Merged
SuperQ
added a commit
that referenced
this pull request
May 21, 2024
SuperQ
added a commit
that referenced
this pull request
May 21, 2024
Check that the PSI metrics are returned in order to avoid nil pointer dereference. * Update fixutre to match real-world samples. Fixes: #3015 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
May 21, 2024
Merged
SuperQ
added a commit
that referenced
this pull request
May 21, 2024
Check that the PSI metrics are returned in order to avoid nil pointer dereference. * Update fixutre to match real-world samples. Fixes: #3015 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
May 21, 2024
SuperQ
added a commit
that referenced
this pull request
May 21, 2024
Check that the PSI metrics are returned in order to avoid nil pointer dereference. * Update fixutre to match real-world samples. Fixes: #3015 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
May 21, 2024
rexagod
pushed a commit
to rexagod/node_exporter
that referenced
this pull request
May 23, 2024
* [BUGFIX] Fix CPU seconds on Solaris prometheus#2963 * [BUGFIX] Sign Darwin/MacOS binaries prometheus#3008 * [BUGFIX] Fix pressure collector nil reference prometheus#3016 Signed-off-by: Ben Kochie <superq@gmail.com>
rexagod
pushed a commit
to rexagod/node_exporter
that referenced
this pull request
May 23, 2024
* [BUGFIX] Fix CPU seconds on Solaris prometheus#2963 * [BUGFIX] Sign Darwin/MacOS binaries prometheus#3008 * [BUGFIX] Fix pressure collector nil reference prometheus#3016 Signed-off-by: Ben Kochie <superq@gmail.com>
rexagod
pushed a commit
to rexagod/node_exporter
that referenced
this pull request
May 23, 2024
* [BUGFIX] Fix CPU seconds on Solaris prometheus#2963 * [BUGFIX] Sign Darwin/MacOS binaries prometheus#3008 * [BUGFIX] Fix pressure collector nil reference prometheus#3016 Signed-off-by: Ben Kochie <superq@gmail.com>
rexagod
pushed a commit
to rexagod/node_exporter
that referenced
this pull request
May 23, 2024
* [BUGFIX] Fix CPU seconds on Solaris prometheus#2963 * [BUGFIX] Sign Darwin/MacOS binaries prometheus#3008 * [BUGFIX] Fix pressure collector nil reference prometheus#3016 Signed-off-by: Ben Kochie <superq@gmail.com>
rexagod
pushed a commit
to rexagod/node_exporter
that referenced
this pull request
May 24, 2024
* [BUGFIX] Fix CPU seconds on Solaris prometheus#2963 * [BUGFIX] Sign Darwin/MacOS binaries prometheus#3008 * [BUGFIX] Fix pressure collector nil reference prometheus#3016 Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the PSI metrics are returned in order to avoid nil pointer dereference.
Fixes: #3015