-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor node-mixin as node-observ-lib #2861
base: master
Are you sure you want to change the base?
Refactor node-mixin as node-observ-lib #2861
Conversation
* Add node-observ-lib * Remove trends support (not in 10.0 schema) * Make filteringSelector for logs dashboard configurable * Temp change dependency (until PR is merged for commonlib) * Refactor config * Update jsonnetfile.json * Update README * Add separate loki example * Add sep file example Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
Just a little question : why don't you render dashboards with .json suffix? |
Nothing specific, It was a little bit more convenient to reference dashboards by key ( |
If this is intended to replace the |
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
150c28c
to
c75a766
Compare
|
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
Just let me know, if what do you think I should do to merge this :) |
NOTE: I put this observ-lib(mixin) into separate folder due to some incompatibilities with old mixin like:
Similar to windows-observ-lib, node-observ-lib is created, using many panels from commonlib:. It also refactors everything from node-mixin by using grafonnet (v10 schema).
Node observability lib would allow:
Uid
andfilteringSelector
are used to avoid conflicts).To learn more about suggested mixin packaging format (observ-lib) you can check dataless example here.
What is recreated/moved from old node-mixin:
Added/Updated: