Add MeterAdapter support for .NET 8 static meter/instrument tags. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tags are set on the meter and/or instrument at creation time, and are automatically added to the measurements' labels. This required a little bit of internal reworking of MeterAdapter so that the static label values are stored into the metric context. I re-organized the code of OnMeasurementRecorded to re-use code between the metric types better, as I had to move the label value pool fetch to be gotten AFTER the metric context. Added a target framework for .NET 8, since we obviously need it for the new feature. I multi-targeted the tests to both .NET 7 and .NET 8 to make sure I didn't break anything. Added these to the example and wrote tests for them too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tags are set on the meter and/or instrument at creation time, and are automatically added to the measurements' labels.
This required a little bit of internal reworking of MeterAdapter so that the static label values are stored into the metric context. I re-organized the code of OnMeasurementRecorded to re-use code between the metric types better, as I had to move the label value pool fetch to be gotten AFTER the metric context.
Added a target framework for .NET 8, since we obviously need it for the new feature. I multi-targeted the tests to both .NET 7 and .NET 8 to make sure I didn't break anything.
Added these to the example and wrote tests for them too.