Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MetricsUrl for HttpMetricsMiddleware #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Isitar
Copy link

@Isitar Isitar commented Apr 1, 2022

This extends the funcitonality for the CaptureMetricsUrl to specify another metrics url.

@sandersaares
Copy link
Member

I had some mixed feelings about the original implementation for exactly this reason - it only worked for the default URL - so it is good to see a PR on this topic. However, I also have mixed feelings about this approach to solve it - we put the burden on the user. Can we instead come up with a way to always do the right thing and just auto-detect the right URL or similar?

@Isitar
Copy link
Author

Isitar commented Jan 2, 2023

This implementation has a default to /metrics so everything works the same as before. More advanced use cases like mine can overwrite the url.

What do you mean by auto detecting? In my use case i wanted it to be under /api/metrics, there is no real hint in the project that it should be hosted there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants