-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] add aws-node exporter #4474
base: main
Are you sure you want to change the base?
[kube-prometheus-stack] add aws-node exporter #4474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not like to pull vendor specific services into kube-prometheus-stack.
I would advise you to add thé service monitor in the aws exporter upstream chart where it makes more sense :) |
Hello @QuentinBisson & @jkroepke, thx for checking this PR. |
f7e4327
to
2030708
Compare
Signed-off-by: Michael Borens <michael.borens@contentsquare.com>
Signed-off-by: Michael Borens <michael.borens@contentsquare.com>
Signed-off-by: Michael Borens <michael.borens@contentsquare.com>
2030708
to
dd366ba
Compare
Yes I would suggest you try to add the chart next to the aws cni one yes unless aws has a public chart repo where this would fit |
What this PR does / why we need it
Hello, as part of our project to migrate from old prometheus stack deployed independently, we moved to prometheus operator.
Previously we had a job in our config to get metrics from pod aws-node deployed on our EKS cluster.
Instead of declare an additionalScrape config I would like to continue on the new logic (serviceMonitor) to get metrics
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)As part of our project to migrate from old prometheus stack deployed independently, we moved to prometheus operator.
Previously we had a job in our config to get metrics from pod aws-node deployed on our EKS cluster.
Instead of declaring an additionalScrape config I would like to continue on the new logic (serviceMonitor) to get metrics from pods.
Special notes for your reviewer
I've generated manifest and deployed them on my cluster
Then I'm able to query all metrics
Checklist
[prometheus-couchdb-exporter]
)