Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy mdbook in guide folder, preserve branch history #367

Merged
merged 1 commit into from Jan 23, 2024

Conversation

flodolo
Copy link
Contributor

@flodolo flodolo commented Jan 23, 2024

This builds the book in a guide subfolder, and preserves the history of the gh-pages branch (in case of issues).

Fixes #366

@flodolo flodolo requested a review from eemeli January 23, 2024 13:24
@flodolo
Copy link
Contributor Author

flodolo commented Jan 23, 2024

It's hard to tell if this is enough to fix the issue 🤔

On my fork I can see the pages on /guide, but is that enough?
https://flodolo.github.io/fluent/guide/

Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should fix the issue.

@flodolo flodolo merged commit 7d3bc42 into projectfluent:master Jan 23, 2024
1 check passed
@flodolo flodolo deleted the mdbook_fix branch January 23, 2024 13:51
@flodolo
Copy link
Contributor Author

flodolo commented Jan 23, 2024

Thanks, let's check in a couple of minutes 🤞🏼

I confess I'm quite confused on how projectfluent.org is set up.

@flodolo
Copy link
Contributor Author

flodolo commented Jan 23, 2024

I can see the correct gitbook output in https://projectfluent.org/fluent/guide/ 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax guide seems to be down
2 participants