Smb detect linux and windows

[Puben]

Template / PR Information

While playing around with Nuclei for SMB stuff I noticed that the existing smb-detect template does not match on my Samba test setup. I believe this PR would match both Windows based SMB-servers and Samba SMB-servers.

Only changed the tag to include "linux" and condition from "and" to "or"

Attached screenshots for reference

• Change request for smb-detect.yaml
• References: https://github.com/projectdiscovery/nuclei-templates/blob/98671ddba79a35ff216ae39d0eb2756b24795cf1/network/detection/smb-detect.yaml

Template Validation

I've validated this template locally?

• YES
• NO

Additional References:

• Nuclei Template Creation Guideline
• Nuclei Template Matcher Guideline
• Nuclei Template Contribution Guideline
• PD-Community Discord server

[GeorginaReeder]

Thanks so much for your contribution @Puben , we appreciate it!

[pussycat0x]

Hi @Puben Hi, I rewrote this template for Samba detection. Please review it and let me know your thoughts.

id: samba-detect

info:
  name: Samba - Detection
  author: pussycat0x
  severity: info
  description: |
    Samba allows file and print sharing between computers running Microsoft Windows and computers running Unix. It is an implementation of dozens of services and a dozen protocols, including: NetBIOS over TCP/IP (NBT) SMB (known as CIFS in some versions)
  metadata:
    max-request: 1
    shodan-query: "port:445"
  tags: js,network,samba,detect,linux

javascript:
  - code: |
      let m = require("nuclei/smb");
      let c = new m.SMBClient();
      let response = c.ConnectSMBInfoMode(Host, Port);

      const conditionsMet = (response.SupportV1 === true  && response.Version.VerString === "SMB 1.0");

      if (conditionsMet) {

      if (response.NTLM === "") {
      printedValue = "Samba detected";
      } else {
      printedValue = response.NTLM;
      }
      }
      else {
      process.exit(1);
      }

    args:
      Host: "{{Host}}"
      Port: 445

    extractors:
      - type: dsl
        dsl:
          - response

[Puben]

That is a way cleaner way to do it! Very cool 👍