Globalconnections overloadmanager #6308
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Epps <seth.d.epps@gmail.com>
…rce monitor for overload manager
seth-epps
commented
Apr 3, 2024
| // | ||
| // This is disbled by default | ||
| // +optional | ||
| OMEnforcedHealth *HealthConfig `json:"om_enforced_health,omitempty"` |
There was a problem hiding this comment.
This needs to be camel case
seth-epps
commented
Apr 3, 2024
| // OMEnforcedHealthListener holds configuration for an envoy listener | ||
| // that enforces the overload manager actions, like global downstream | ||
| // connection limits. | ||
| OMEnforcedHealthListener *OMEnforcedHealthListenerConfig `yaml:"om_enforced_health_listener,omitempty"` |
There was a problem hiding this comment.
similar to the other struct, this needs to be camelcase
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
skriss
removed
the
lifecycle/stale
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
sunjayBhatia
removed
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Current draft to address #6309 -- it is missing tests and the configuration APIs are loosely defined, which I'm hoping to get feedback on in the linked issue