internal/contour: Add Support for custom headers on HTTPProxy level #5586

deveshk0 · 2023-07-25T23:37:13Z

Introduces support for request and repsonse headers on http proxy level

github-actions · 2023-07-25T23:38:57Z

Hi @deveshk0! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

github-actions · 2023-08-10T00:21:34Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

deveshk0 · 2023-08-13T21:03:03Z

can some please have a look into this?

github-actions · 2023-08-28T00:18:26Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

deveshk0 · 2023-09-05T10:23:41Z

is this planned for next release?

github-actions · 2023-09-20T00:18:27Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

skriss

@deveshk0 thanks for the PR, this is looking good. Left a few comments to address.

apis/projectcontour/v1/httpproxy.go

skriss · 2023-10-04T19:00:33Z

internal/dag/httpproxy_processor.go

+	)
+	requestHeadersPolicyDefined := false
+	responseHeadersPolicyDefined := false
+	if proxy.Spec.VirtualHost.RequestHeadersPolicy != nil {


I think we will want to reuse the existing logic we have for processing these HeaderPolicies - in particular e.g. headersPolicyRoute. That function has some better validation and also handles parsing dynamic header values (see https://projectcontour.io/docs/1.26/config/request-rewriting/#dynamic-header-values), which I think we should support for vhost header policies as well. We'd want to pass false as the second argument since we won't support rewriting the Host header for vhosts.

internal/dag/httpproxy_processor.go

internal/envoy/v3/route.go

skriss

Please also follow the instructions in https://github.com/projectcontour/contour/actions/runs/6410166216/job/17403616430?pr=5586 to add a changelog describing the change for users.

deveshk0 · 2023-10-05T21:10:05Z

@skriss Thanks for the review I will update to suggested changes.

github-actions · 2023-10-20T00:18:44Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2023-11-19T00:21:39Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

deveshk0 · 2023-11-23T04:19:29Z

@skriss Can you please open this? I will finish it this week

deveshk0 · 2024-01-17T22:56:10Z

@sunjayBhatia @skriss @m-yosefpor all requested changes have been added, I have rebased it also, Please have a look

deveshk0 · 2024-01-17T23:22:33Z

Please also follow the instructions in https://github.com/projectcontour/contour/actions/runs/6410166216/job/17403616430?pr=5586 to add a changelog describing the change for users.

done

codecov · 2024-01-18T00:02:02Z

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.31%. Comparing base (c3d6cb4) to head (9993502).
Report is 50 commits behind head on main.

❗ Current head 9993502 differs from pull request most recent head 86b578c. Consider uploading reports for the commit 86b578c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5586      +/-   ##
==========================================
- Coverage   81.56%   81.31%   -0.26%     
==========================================
  Files         133      133              
  Lines       15801    15797       -4     
==========================================
- Hits        12888    12845      -43     
- Misses       2617     2656      +39     
  Partials      296      296

Files	Coverage Δ
internal/dag/dag.go	`98.40% <ø> (ø)`
internal/envoy/v3/route.go	`80.06% <100.00%> (+0.18%)`	⬆️
internal/dag/httpproxy_processor.go	`90.84% <50.00%> (-0.57%)`	⬇️

... and 10 files with indirect coverage changes

m-yosefpor · 2024-01-18T01:34:19Z

LGTM. thanks.

github-actions · 2024-02-08T00:19:11Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

m-yosefpor · 2024-02-08T09:35:21Z

not stale

sunjayBhatia

For full test coverage over the precedence rules of setting header policies in different places on an HTTPRoute I think we should probably add an integration/featuretests test which should also serve as a kind of documentation for how the precedence works. A test for this would:

live in internal/featuretests/headerpolicy_test.go
configure an HTTPProxy with header policies at all levels (global, virtualhost, route, service) for the same Header name with different values
expect the Route/Cluster/etc are configured as expected

sunjayBhatia · 2024-02-08T23:29:24Z

internal/dag/httpproxy_processor.go

+	}
+
+	requestHeadersPolicy, err := headersPolicyRoute(proxy.Spec.VirtualHost.RequestHeadersPolicy, false, dynamicHeaders)
+	if err != nil {


lets add some negative test cases for if validation fails on virtualhost specified header policies

this can go alongside the other test added in builder_test.go

sunjayBhatia · 2024-02-08T23:41:25Z

apis/projectcontour/v1/httpproxy.go

@@ -327,6 +327,24 @@ type VirtualHost struct {
 	// +optional
 	JWTProviders []JWTProvider `json:"jwtProviders,omitempty"`

+	// The policy for managing request headers during proxying.
+	// Headers are appended to requests in the following order,
+	// weighted cluster level headers,


nit: let's maybe not use "weighted cluster" just since that is an explicitly Envoy rather than Contour-specific term, we can use Service instead I think

sunjayBhatia · 2024-02-08T23:43:08Z

internal/envoy/v3/route_test.go

+			vh: &dag.VirtualHost{
+				Name: "example.com",
+				RequestHeadersPolicy: &dag.HeadersPolicy{
+					Set: map[string]string{


We're only testing Set and Remove here though the implementation also includes supporting the Add operation for headers. Technically the HTTPProxy API does not have an Add mechanism so we could either omit it in the implementation or just leave it but make sure it is tested here

Added test cases for Add case also

deveshk0 · 2024-02-09T10:42:38Z

Thanks, @sunjayBhatia for the review I will add the requested changes.

github-actions · 2024-02-24T00:18:13Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

m-yosefpor · 2024-02-24T01:01:49Z

/ remove-lifecycle-stale

github-actions · 2024-03-21T00:20:19Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

Introduces support for request and repsonse headers on http proxy level Fixes: projectcontour#5576 Signed-off-by: Devesh Kumar <vrshu112@gmail.com>

github-actions · 2024-04-12T00:19:38Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-05-01T00:21:46Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

deveshk0 requested a review from a team as a code owner July 25, 2023 23:37

deveshk0 requested review from tsaarni and stevesloka and removed request for a team July 25, 2023 23:37

deveshk0 force-pushed the main branch from 1d25edf to 563a21d Compare July 26, 2023 22:48

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2023

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2023

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2023

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2023

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2023

skriss self-requested a review October 4, 2023 18:41

skriss added release-note/minor A minor change that needs about a paragraph of explanation in the release notes. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 4, 2023

skriss closed this Oct 4, 2023

skriss reopened this Oct 4, 2023

skriss requested changes Oct 4, 2023

View reviewed changes

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2023

github-actions bot closed this Nov 19, 2023

skriss reopened this Dec 6, 2023

deveshk0 requested a review from sunjayBhatia January 17, 2024 22:56

deveshk0 force-pushed the main branch from bec1c98 to da12bda Compare January 17, 2024 23:00

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2024

sunjayBhatia requested changes Feb 8, 2024

View reviewed changes

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2024

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2024

deveshk0 force-pushed the main branch 2 times, most recently from 6b4ed1f to 27739ff Compare March 6, 2024 23:24

sunjayBhatia self-requested a review March 6, 2024 23:24

deveshk0 force-pushed the main branch from 27739ff to 9993502 Compare March 6, 2024 23:40

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 21, 2024

internal/contour: Add Support for custom headers on HTTPProxy level

86b578c

Introduces support for request and repsonse headers on http proxy level Fixes: projectcontour#5576 Signed-off-by: Devesh Kumar <vrshu112@gmail.com>

deveshk0 force-pushed the main branch from 9993502 to 86b578c Compare March 26, 2024 16:35

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 12, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

internal/contour: Add Support for custom headers on HTTPProxy level #5586

internal/contour: Add Support for custom headers on HTTPProxy level #5586

deveshk0 commented Jul 25, 2023

github-actions bot commented Jul 25, 2023

github-actions bot commented Aug 10, 2023

deveshk0 commented Aug 13, 2023

github-actions bot commented Aug 28, 2023

deveshk0 commented Sep 5, 2023

github-actions bot commented Sep 20, 2023

skriss left a comment

skriss Oct 4, 2023

deveshk0 Dec 27, 2023

skriss left a comment

deveshk0 commented Oct 5, 2023

github-actions bot commented Oct 20, 2023

github-actions bot commented Nov 19, 2023

deveshk0 commented Nov 23, 2023

deveshk0 commented Jan 17, 2024

deveshk0 commented Jan 17, 2024

codecov bot commented Jan 18, 2024 •

edited

m-yosefpor commented Jan 18, 2024

github-actions bot commented Feb 8, 2024

m-yosefpor commented Feb 8, 2024

sunjayBhatia left a comment

sunjayBhatia Feb 8, 2024

sunjayBhatia Feb 8, 2024

sunjayBhatia Feb 8, 2024

deveshk0 Mar 6, 2024

sunjayBhatia Feb 8, 2024

deveshk0 Mar 6, 2024

deveshk0 commented Feb 9, 2024

github-actions bot commented Feb 24, 2024

m-yosefpor commented Feb 24, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Apr 12, 2024

github-actions bot commented May 1, 2024

internal/contour: Add Support for custom headers on HTTPProxy level #5586

Are you sure you want to change the base?

internal/contour: Add Support for custom headers on HTTPProxy level #5586

Conversation

deveshk0 commented Jul 25, 2023

github-actions bot commented Jul 25, 2023

github-actions bot commented Aug 10, 2023

deveshk0 commented Aug 13, 2023

github-actions bot commented Aug 28, 2023

deveshk0 commented Sep 5, 2023

github-actions bot commented Sep 20, 2023

skriss left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skriss left a comment

Choose a reason for hiding this comment

deveshk0 commented Oct 5, 2023

github-actions bot commented Oct 20, 2023

github-actions bot commented Nov 19, 2023

deveshk0 commented Nov 23, 2023

deveshk0 commented Jan 17, 2024

deveshk0 commented Jan 17, 2024

codecov bot commented Jan 18, 2024 • edited

Codecov Report

m-yosefpor commented Jan 18, 2024

github-actions bot commented Feb 8, 2024

m-yosefpor commented Feb 8, 2024

sunjayBhatia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deveshk0 commented Feb 9, 2024

github-actions bot commented Feb 24, 2024

m-yosefpor commented Feb 24, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Apr 12, 2024

github-actions bot commented May 1, 2024

codecov bot commented Jan 18, 2024 •

edited