-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ID handling in IIIF helper methods #2863
base: main
Are you sure you want to change the base?
Conversation
b2e2a78
to
8be39df
Compare
The latter bug ( For now we have an initializer that calls |
The manifest controller expects the URL to include the exhibit ID and resource ID, but the indexer has been using the ID of the resource's FeaturedImage instead. This doesn't always cause issues, because in many situations the ID of a resource's FeaturedImage and the ID of the resource itself have the same numerical representation. But those numbers can fall out of sync, and manifests will fail to load.
This matches the behavior of the other helpers and of CarrierwaveFileResolver
bumping this again |
Is it possible to add a test that can demonstrate how this fix works to fix the problem? |
@jcoyne we should be able to have a test that sets up a |
The manifest controller expects the URL to include the exhibit ID and resource ID, but the indexer has been using the ID of the resource's
FeaturedImage
instead. This doesn't always cause issues, because in many situations the ID of a resource'sFeaturedImage
and the ID of the resource itself have the same numerical representation. But those numbers can fall out of sync, and manifests will fail to load.Meanwhile, update the
iiif_service#info
method to expect the ID of aFeaturedImage
rather than aResource
. This brings it in line with the otherRIIIFService
helper methods and is howSpotlight::CarrierwaveFileResolver
behaves.