When a resource is deleted, remove its index object too #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
reviewed
Mar 28, 2019
| return unless write? | ||
|
|
||
| blacklight_solr.delete_by_query( | ||
| "#{Spotlight::Engine.config.resource_global_id_field}:#{to_global_id}" |
There was a problem hiding this comment.
I think there's probably another necessary component to this to deal with solr documents that are generated into the index from multiple resources. To start with, we may need to do additional bookkeeping to track resources -> solr ids in the database.
There was a problem hiding this comment.
So, we need to check that resource_global_id_field is only a single element and that single element is this resource?
There was a problem hiding this comment.
And do the work to make sure resource_global_id_field is multi-valued when necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.