hv: console reads all input chars in one poll #8565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For uart console, some control keys are defined as byte sequences, such as: * up arrow - 0x1b/0x5b/0x41 * F8 - 0x1b/0x5b/0x31/0x39/0x7e Currently hv console only read one char per poll. When guest vuart console is active, those byte sequences may not be sent to guest vuart in good timing due to the poll interval. Thus control keys such as up/down can not be used in shell or vim. The solution is to read all input chars in one poll, so that control keys can be received by guest OS properly. Tracked-On: projectacrn#8564 Signed-off-by: Wu Zhou <wu.zhou@intel.com> Reviewed-by: Junjie Mao <junjie.mao@intel.com>
junjiemao1
approved these changes
Mar 8, 2024
|
start to run premerge test |
1 similar comment
|
start to run premerge test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For uart console, some control keys are defined as byte sequences, such as:
Currently hv console only read one char per poll.
When guest vuart console is active, those byte sequences may not be sent to guest vuart in good timing due to the poll interval. Thus control keys such as up/down can not be used in shell or vim.
The solution is to read all input chars in one poll, so that control keys can be received by guest OS properly.
Tracked-On: #8564
Reviewed-by: Junjie Mao junjie.mao@intel.com