config_tools: fix pre_launch VM ACPI table #8553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current acpi table adopts the DWordAddressSpace to present the PCI hole above 4G. It is not correct, because DWordAddressSpace is used to present the mem space below 4G. Follow the ACPI spec, modify to QWordAddressSpace here. Refer: 19.6.22. CreateQWordField (Create 64-Bit Buffer Field) Tracked-On: projectacrn#8552 Signed-off-by: Zhangwei6 <wei6.zhang@intel.com> Reviewed-by: Junjie Mao <junjie.mao@intel.com>
6ZhangWei
force-pushed
the
fix_preVM_acpi
branch
from
f073c6b
to
1bc8c4c
Compare
NanlinXie
approved these changes
Feb 1, 2024
|
start to run premerge test |
1 similar comment
|
start to run premerge test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current acpi table adopts the DWordAddressSpace to present
the PCI hole above 4G. It is not correct, because DWordAddressSpace
is used to present the mem space below 4G.
Follow the ACPI spec, modify to QWordAddressSpace here.
Refer: 19.6.22. CreateQWordField (Create 64-Bit Buffer Field)
Tracked-On: #8552
Signed-off-by: Zhangwei6 wei6.zhang@intel.com
Reviewed-by: Junjie Mao junjie.mao@intel.com