New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Debian packaging postinst partition finding #8529
base: master
Are you sure you want to change the base?
Conversation
@xzhangxa please add Tracked-On |
If the root partition is bind mounted with / and another, the current postinst script (using command lsblk) will fail to find the partition: $type will be "/" only and cause the following command may find the wrong partition. Ubuntu 22.04 desktop with firefox snap by default: ``` > lsblk nvme0n1 259:19 0 931.5G 0 disk ├─nvme0n1p1 259:20 0 243M 0 part /boot/efi ├─nvme0n1p2 259:21 0 927.5G 0 part /var/snap/firefox/common/host-hunspell │ / ``` And current command forces the root partition to be ext4. This patch fixes the two issues. Tracked-On: projectacrn#8532 Signed-off-by: Xin Zhang <xin.x.zhang@intel.com>
I'd like to change the code a little from using So Change to use |
start to run premerge test |
Please 'terryzouhao' or 'NanlinXie' approve this patch. |
If the root partition is bind mounted with / and another, the current postinst script (using command lsblk) will fail to find the partition: $type will be "/" only and cause the following command may find the wrong partition.
And current command forces the root partition to be ext4.
This patch fixes the two issues.
Two setups with bind mounted root partition;
Ubuntu 22.04 desktop, bind mount firefox snap:
Windows WSL2, bind mount WSLg:
Tracked-On: #8532