Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added redis tests #2412

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Added redis tests #2412

wants to merge 3 commits into from

Conversation

peusebiu
Copy link
Collaborator

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

elee1766 and others added 2 commits April 30, 2024 14:32
Currently, we have dynamoDB as the remote shared cache but ideal only
for the cloud use case.
For on-prem use case, add support for redis.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 65.25424% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 92.71%. Comparing base (4671e41) to head (37d1b15).

❗ Current head 37d1b15 differs from pull request most recent head 298b0cd. Consider uploading reports for the commit 298b0cd to get more accurate results

Files Patch % Lines
pkg/storage/cache/redis.go 64.65% 30 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
- Coverage   92.86%   92.71%   -0.15%     
==========================================
  Files         167      168       +1     
  Lines       22060    22178     +118     
==========================================
+ Hits        20485    20562      +77     
- Misses        982     1012      +30     
- Partials      593      604      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants