Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Azure Blob Storage implementation #2223

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jkroepke
Copy link

@jkroepke jkroepke commented Feb 1, 2024

What type of PR is this?

feature

Which issue does this PR fix:

#2221

What does this PR do / Why do we need it:

Native support for Azure blob storage

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

Native support for Azure Blob storage

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jkroepke
Copy link
Author

jkroepke commented Feb 1, 2024

This PR is marked as WIP, since it depends on the distribution v3 packages which is not released yet.

@peusebiu
Copy link
Collaborator

peusebiu commented Feb 2, 2024

Hello @jkroepke Isn't it possbile to reuse the s3 driver? and make it more generic. in theory it should work with all major cloud providers.

@jkroepke
Copy link
Author

jkroepke commented Feb 2, 2024

in theory it should work with all major cloud providers.

In practice, there is no S3 Compatibility API at Azure. The distribution project maintains an azure driver which I re-use here:

https://github.com/distribution/distribution/blob/main/docs/content/storage-drivers/azure.md

If upstream distribution project nativly support Azure, it should not be a major issue for zot? I thought, zot fully depends on it and the usage for storage driver is transparent.

@peusebiu
Copy link
Collaborator

peusebiu commented Feb 2, 2024

in theory it should work with all major cloud providers.

In practice, there is no S3 Compatibility API at Azure. The distribution project maintains an azure driver which I re-use here:

https://github.com/distribution/distribution/blob/main/docs/content/storage-drivers/azure.md

If upstream distribution project nativly support Azure, it should not be a major issue for zot? I thought, zot fully depends on it and the usage for storage driver is transparent.

I see, understood, ok.

@rchincha rchincha added this to the v2.1.0 milestone Mar 1, 2024
@rchincha
Copy link
Contributor

rchincha commented Mar 1, 2024

Let's target this for v2.1.0

@jkroepke
Copy link
Author

jkroepke commented Mar 1, 2024

Let's target this for v2.1.0

A requirement for this PR would be github.com/docker/distribution v3.0.0-alpha.1 or higher. Thats something that should not be part of the PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants