feat: redis dedup backend #2005
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elee1766
requested review from
peusebiu,
rchincha and
andaaron
as code owners
|
I would love to see Redis support added. Are you still working on this? |
hi yes, I plan to see this pr to completion |
rchincha
pushed a commit
to rchincha/zot
that referenced
this pull request
Apr 8, 2024
peusebiu
pushed a commit
to peusebiu/zot
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi ! im attempting to implement #2004
im not done yet (i need to add the configuration switch case and look at other things), but i thought i would push up some progress, and maybe if this is an awful idea or i am doing something very bad code wise i should know.
it passes tests using an embedded redis, so that is good
What does this PR do / Why do we need it:
adds a redis backend for the dedup cache
Testing done on this change:
i've copied the test from bolt and ran it with embedded redis.
Automation added to e2e:
not any. should i add a test that spins up redis docker image?
Will this break upgrades or downgrades?
it will break downgrades if the user downgrades to a version that no longer supports redis and they are using redis
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.