Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): specific images #1952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peusebiu
Copy link
Collaborator

added the option to sync specific images(docker/oci) specific repo:tags can be set in sync config

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@peusebiu peusebiu force-pushed the specific_imgs branch 3 times, most recently from 6d2be30 to 16f3a49 Compare October 23, 2023 16:25
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1952 (0638160) into main (3e6053e) will decrease coverage by 0.01%.
The diff coverage is 98.35%.

@@            Coverage Diff             @@
##             main    #1952      +/-   ##
==========================================
- Coverage   89.87%   89.86%   -0.01%     
==========================================
  Files         158      158              
  Lines       26978    27092     +114     
==========================================
+ Hits        24246    24347     +101     
- Misses       2012     2020       +8     
- Partials      720      725       +5     
Files Coverage Δ
pkg/extensions/extension_sync.go 90.83% <100.00%> (+1.65%) ⬆️
pkg/extensions/sync/content.go 100.00% <100.00%> (ø)
pkg/extensions/sync/on_demand.go 87.70% <100.00%> (+2.12%) ⬆️
pkg/extensions/sync/service.go 98.18% <100.00%> (+2.58%) ⬆️
pkg/extensions/sync/sync.go 93.33% <94.64%> (+1.66%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peusebiu peusebiu force-pushed the specific_imgs branch 2 times, most recently from ac152fc to c5cf7b8 Compare October 30, 2023 15:15
@peusebiu peusebiu marked this pull request as ready for review October 30, 2023 17:05
added the option to sync specific images(docker/oci)
specific repo:tags can be set in sync config

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
@rchincha rchincha added this to the v2.0.1 milestone Nov 8, 2023
@rchincha rchincha modified the milestones: v2.0.1, v2.1.0 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants