Various improvements and JSON-friendly additions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements an allowlist (sometimes called a "greenlist") which specifies tables that ARE exposed. If populated, no other tables will be returned, for enhanced security. - When there is no JSON response, instead of a string, an empty object is returned. - Removes references to "blacklist," which is politically touchy, and replaces with "blocklist."
Updated README to include all changes
|
To achieve PHP <5.4 compatibility, I believe the only change would be replacing "[]" on line 444 of class-.db-api.php with array(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request accomplishes a few things:
This has been tested on PHP 7.3, but should work on PHP 5.4+.