-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4742] OCP Network API #5088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5088 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 376 375 -1
Lines 31317 31170 -147
Branches 3759 3730 -29
=======================================
- Hits 29474 29323 -151
- Misses 1174 1179 +5
+ Partials 669 668 -1 |
…-node-network-api
We do this in the back populate SQL. Setting it in the bakery model for consistency.
samdoran
added
the
ocp-smoke-tests
pr_check will build the image and run ocp + ocp on [clouds] smoke tests
label
May 28, 2024
…-node-network-api
They are not used for the node network models
Network data comes from the cloud bill
lcouzens
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ocp-smoke-tests
pr_check will build the image and run ocp + ocp on [clouds] smoke tests
smokes-required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4742
Description
This change will add the network API to the provider map for OpenShift.
Testing
make load-test-customer-data test_source=azure
http://localhost:8000/api/cost-management/v1/reports/openshift/network/
Look at the data in the database
If you only have one cluster, this data will be the same as above, if you have more than one the totals will match but the per day records will differ.
http://localhost:8000/api/cost-management/v1/reports/openshift/network/?group_by[node]=*
If you only have one cluster, this data will be the same as above, if you have more than one the totals will match but the per day records will differ.
Look at the data
Release Notes