Changing user_endpoints back to non async since that is breaking the backwards compatibility with after and iteratorAccumulator #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
May 8, 2024
brdandu
commented
- After helper waits for the promises to finish. However turning the user_endpoints to async led to accumulator not populate before the iteratorAccumulator tried to access it.
- Turned user-endpoints helper back to no asnyc
- Added test so that this is covered when we actually fix this issue with accumulators
- JIRA: ZAPP-1376
paulr34
approved these changes
May 8, 2024
…backwards compatibility with after and iteratorAccumulator - After helper waits for the promises to finish. However turning the user_endpoints to async led to accumulator not populate before the iteratorAccumulator tried to access it. - Turned user-endpoints helper back to no asnyc - Added test so that this is covered when we actually fix this issue with accumulators - JIRA: ZAPP-1376
brdandu
force-pushed
the
bug/fixAccumulatorIssuesWithWaitedPromises/ZAPP-1376
branch
from
4e21a42
to
61ff51a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.