Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merged argument to all_user_clusters #1216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Nov 22, 2023

When generating matter code, in some cases we do not care about cluster side - specifically clusters in matter have a single definition without client/server side.

Provide the ability to select all clusters and ignore the "side" part and not have client/server duplicates.

This is to enhance project-chip/connectedhomeip#30605 to not have duplicated cluster entries.

Changes

  • support and document a "merged" side
  • updated grouping to not consider side if side is merged
  • made order by hard-coded because the doOrder was already hardcoded.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c472c0) 64.95% compared to head (2a73c9c) 64.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1216   +/-   ##
=======================================
  Coverage   64.95%   64.95%           
=======================================
  Files         187      187           
  Lines       19329    19327    -2     
  Branches     4127     4126    -1     
=======================================
- Hits        12555    12554    -1     
+ Misses       6774     6773    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants