cluster model decoupling - declare the codegen (ember) version and implement iteration #33345
+935
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
force-pushed
the
imdm/2-ember-iterate
branch
from
5892a36
to
30812a9
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
|
PR #33345: Size comparison from e887e58 to d8b8433 Increases (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
cecille
reviewed
May 13, 2024
… may not be ideal still
… vs value duality still needs some work
|
PR #33345: Size comparison from fa28631 to c1fc803 Increases (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (3 builds for bl702l, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33345: Size comparison from fa28631 to eba45ae Increases (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (3 builds for bl702l, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
cecille
reviewed
May 17, 2024
|
PR #33345: Size comparison from 3c6bd79 to 22e9df0 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33345: Size comparison from b5d13a7 to 63a7685 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
cecille
approved these changes
May 22, 2024
| # limitations under the License. | ||
| import("//build_overrides/chip.gni") | ||
|
|
||
| # The sources in this directory are TIGHLY coupled with code-generated data models |
There was a problem hiding this comment.
Suggested change
| # The sources in this directory are TIGHLY coupled with code-generated data models | |
| # The sources in this directory are TIGHTLY coupled with code-generated data models |
| namespace chip { | ||
| namespace app { | ||
|
|
||
| class CodegenDataModel : public chip::app::InteractionModel::Model |
There was a problem hiding this comment.
Please document the purpose of this class?
|
|
||
| /// attribute tree iteration | ||
| EndpointId FirstEndpoint() override; | ||
| EndpointId NextEndpoint(EndpointId before) override; |
There was a problem hiding this comment.
What's the reasoning behind this style of iteration API, compared to following the STL iterator paradigm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a mostly-empty
CodegenDataModel::Modelexcept attribute-tree iteration.Implement the attribute-tree iteration and add unit tests via ember mocks.
Changes contained:
src/app/codegen-interaction-modelto contain a interaction model that uses code-generated data (i.e. ember/zap metadata) for executionInvalidstatic method to iteration types, so it is clear when an invalid value is created