Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial (and shallow) clone note #1611

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Feb 15, 2021

Changes

Add note about partial and shallow clone, with external link describing
them in detail. The note is in Chapter 2 - Getting a repository

Context

Fixes #1597

Add note about partial and shallow clone, with external link describing
them in detail.

Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Copy link
Contributor

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more suggestions coming up, but first follow the "one sentence per line" structure.

book/02-git-basics/sections/getting-a-repository.asc Outdated Show resolved Hide resolved
From @HonkingGoose:
  * Split paragraphs into one sentence each line

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@bagasme
Copy link
Contributor Author

bagasme commented Feb 16, 2021

review ping

Rewording from @HonkingGoose

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@bagasme
Copy link
Contributor Author

bagasme commented Feb 25, 2021

review ping

@ben
Copy link
Member

ben commented Feb 25, 2021

I have two minds on this PR. On the one hand, it's well-written, and valuable info for the reader.

But does it belong in chapter 2? This is where a reader who has never worked with Git before gets their first taste. We deliberately prioritize that first-time experience in this chapter over things like absolute correctness or deep-dives into topics. It seems to me that this content would be a better fit as a section in chapter 7, where there's some room to dig into some common use cases.

Would you want to take a swing at that larger chunk of content?

@bagasme
Copy link
Contributor Author

bagasme commented Feb 27, 2021

@ben ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Partial clone
3 participants