Prettify MD/YAML files #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved via `prettier -w .`
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 2471 2471
Branches 358 358
=========================================
Hits 2471 2471 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
prkumar
approved these changes
Nov 14, 2022
|
🥳 🥳 🥳 🥳 🥳 |
EvaSDK
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
I'm approving the PR because it is good to apply formatting tool to avoid inconsistencies but I think it would be even better to leverage pre-commit and either use prettier hook or add yamlfmt/yamllint and mdformat hooks so these changes can be done while developing. It should also be integrated in Travis so it is checked even if someone forgot to install pre-commit locally. Anyway, these comments are material for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved via
prettier -w .Attention: @prkumar