Fix bug in prepare_candidates; it affected convergence for block size…

… > 1
primme · Feb 25, 2024 · 8c75a5d · 8c75a5d
1 parent 34ea13a
commit 8c75a5d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Make_flags b/Make_flags
@@ -30,7 +30,7 @@ CC       ?= cc
 F77      := gfortran
 FC       := gfortran
 DEFINES  ?= -DF77UNDERSCORE 
-CFLAGS   ?= -O -fPIC -DNDEBUG
+CFLAGS   ?= -O0 -g -fPIC
 FFLAGS   ?= -fno-second-underscore -O
 PRIMME_WITH_HALF ?= no
 ifeq ($(PRIMME_WITH_HALF), yes)

diff --git a/examples/Makefile b/examples/Makefile
@@ -10,7 +10,7 @@ INCLUDE := -I../include
 FINCLUDE := -I../include
 LIBS := ../lib/libprimme.a $(LIBS)
 
-EXAMPLES_C = ex_eigs_dseq ex_eigs_zseq ex_eigs_zseq_normal ex_svds_dseq ex_svds_zseq
+EXAMPLES_C = ex_eigs_dseq ex_eigs_zseq ex_eigs_zseq_normal ex_svds_dseq ex_svds_zseq ex_mine
 EXAMPLES_CXX = ex_eigs_zseqxx ex_svds_zseqxx
 EXAMPLES_F = ex_eigs_dseqf77 ex_eigs_zseqf77 ex_svds_dseqf77 ex_svds_zseqf77 ex_eigs_dseqf90 ex_svds_dseqf90
 

diff --git a/src/eigs/main_iter.c b/src/eigs/main_iter.c
@@ -1533,7 +1533,7 @@ STATIC int prepare_candidates(SCALAR *V, PRIMME_INT ldV, SCALAR *W,
    *recentlyConverged = 0;
    while (1) {
       /* Recompute flags in iev(*blockSize:*blockSize+blockNormsize) */
-      for (i=*blockSize; i<blockNormsSize; i++)
+      for (i = *blockSize; i < *blockSize+blockNormsSize; i++) {
          flagsBlock[i-*blockSize] = flags[iev[i]];
       CHKERR(check_convergence_Sprimme(X ? &X[(*blockSize) * ldV] : NULL, ldV,
             computeXR, R ? &R[(*blockSize) * ldW] : NULL, ldW, computeXR, evecs,