Skip to content

Commit

Permalink
Cleanup old Primitive imports (#2606)
Browse files Browse the repository at this point in the history
* cleanup

* Create three-apples-beg.md

* add color imports to sb

* sb upgrades
  • Loading branch information
langermank committed Apr 9, 2024
1 parent a723b65 commit a03827b
Show file tree
Hide file tree
Showing 8 changed files with 74 additions and 145 deletions.
5 changes: 5 additions & 0 deletions .changeset/three-apples-beg.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": patch
---

Cleanup old Primitive imports
29 changes: 20 additions & 9 deletions docs/.storybook/preview.css
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
@import '@primer/primitives/tokens-next-private/css/base/size/size.css';
@import '@primer/primitives/tokens-next-private/css/base/typography/typography.css';
@import '@primer/primitives/tokens-next-private/css/functional/size/border.css';
@import '@primer/primitives/tokens-next-private/css/functional/size/breakpoints.css';
@import '@primer/primitives/tokens-next-private/css/functional/size/size-coarse.css';
@import '@primer/primitives/tokens-next-private/css/functional/size/size-fine.css';
@import '@primer/primitives/tokens-next-private/css/functional/size/size.css';
@import '@primer/primitives/tokens-next-private/css/functional/size/viewport.css';
@import '@primer/primitives/tokens-next-private/css/functional/typography/typography.css';
@import '@primer/primitives/dist/css/base/size/size.css';
@import '@primer/primitives/dist/css/base/typography/typography.css';
@import '@primer/primitives/dist/css/functional/size/border.css';
@import '@primer/primitives/dist/css/functional/size/breakpoints.css';
@import '@primer/primitives/dist/css/functional/size/size-coarse.css';
@import '@primer/primitives/dist/css/functional/size/size-fine.css';
@import '@primer/primitives/dist/css/functional/size/size.css';
@import '@primer/primitives/dist/css/functional/size/viewport.css';
@import '@primer/primitives/dist/css/functional/typography/typography.css';

/* color */
@import '@primer/primitives/dist/css/functional/themes/light.css';
@import '@primer/primitives/dist/css/functional/themes/light-tritanopia.css';
@import '@primer/primitives/dist/css/functional/themes/light-high-contrast.css';
@import '@primer/primitives/dist/css/functional/themes/light-colorblind.css';
@import '@primer/primitives/dist/css/functional/themes/dark.css';
@import '@primer/primitives/dist/css/functional/themes/dark-colorblind.css';
@import '@primer/primitives/dist/css/functional/themes/dark-dimmed.css';
@import '@primer/primitives/dist/css/functional/themes/dark-high-contrast.css';
@import '@primer/primitives/dist/css/functional/themes/dark-tritanopia.css';
86 changes: 37 additions & 49 deletions docs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
"babel-loader": "^8.2.5",
"clsx": "^1.2.1",
"eslint-plugin-storybook": "^0.6.12",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"storybook": "^7.0.26",
"storybook-addon-pseudo-states": "^2.1.0"
}
Expand Down
49 changes: 0 additions & 49 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
"js-yaml": "^4.1.0",
"postcss": "^8.4.35",
"postcss-calc": "^9.0.1",
"postcss-custom-properties-fallback": "^1.0.2",
"postcss-import": "^16.0.1",
"postcss-load-config": "^5.0.3",
"postcss-scss": "^4.0.5",
Expand Down
29 changes: 1 addition & 28 deletions postcss.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ const sass = require('@csstools/postcss-sass')
const scss = require('postcss-scss')
const scssImport = require('postcss-import')
const { join } = require('path')
const path = require('path')
const fs = require('fs')

module.exports = {
map: {
Expand All @@ -19,31 +17,6 @@ module.exports = {
includePaths: [join(__dirname, 'node_modules')],
outputStyle: process.env.CSS_MINIFY === '0' ? 'expanded' : 'compressed'
}),
autoprefixer,
require('postcss-custom-properties-fallback')({
importFrom: [
() => {
const primitiveFallbacks = [
'color-fallbacks.json',
'base/size/size.json',
'base/typography/typography.json',
'functional/size/border.json',
'functional/size/breakpoints.json',
'functional/size/size-coarse.json',
'functional/size/size-fine.json',
'functional/size/size.json',
'functional/size/viewport.json',
'functional/typography/typography.json',
]
let customProperties = {}
for (const filePath of primitiveFallbacks) {
const fileData = fs.readFileSync(path.join(__dirname, './node_modules/@primer/primitives/tokens-next-private/fallbacks/', filePath), 'utf8')
customProperties = {...customProperties, ...JSON.parse(fileData)}
}

return { customProperties: customProperties };
}
]
}),
autoprefixer
]
}
18 changes: 9 additions & 9 deletions src/primitives/index.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@import '@primer/primitives/tokens-next-private/css/base/size/size';
@import '@primer/primitives/tokens-next-private/css/base/typography/typography';
@import '@primer/primitives/tokens-next-private/css/functional/size/border';
@import '@primer/primitives/tokens-next-private/css/functional/size/breakpoints';
@import '@primer/primitives/tokens-next-private/css/functional/size/size-coarse';
@import '@primer/primitives/tokens-next-private/css/functional/size/size-fine';
@import '@primer/primitives/tokens-next-private/css/functional/size/size';
@import '@primer/primitives/tokens-next-private/css/functional/size/viewport';
@import '@primer/primitives/tokens-next-private/css/functional/typography/typography';
@import '@primer/primitives/dist/css/base/size/size';
@import '@primer/primitives/dist/css/base/typography/typography';
@import '@primer/primitives/dist/css/functional/size/border';
@import '@primer/primitives/dist/css/functional/size/breakpoints';
@import '@primer/primitives/dist/css/functional/size/size-coarse';
@import '@primer/primitives/dist/css/functional/size/size-fine';
@import '@primer/primitives/dist/css/functional/size/size';
@import '@primer/primitives/dist/css/functional/size/viewport';
@import '@primer/primitives/dist/css/functional/typography/typography';
@import './temp-typography-tokens.scss';

0 comments on commit a03827b

Please sign in to comment.