Image a11y sign off updates

[JoshBowdenConcepts]

Summary

Updating the alt tags for the feature stories on Storybook to go above and beyond and be slightly more specific.

List of notable changes:

• updated the alt tags for the feature stories on Storybook to go above and beyond and be slightly more specific.

Supporting resources (related issues, external links, etc):

• https://github.com/github/primer/issues/1002

Contributor checklist:

• All new and existing CI checks pass
• Tests prove that the feature works and covers both happy and unhappy paths
• Any drop in coverage, breaking changes or regressions have been documented above
• New visual snapshots have been generated / updated for any UI changes
• All developer debugging and non-functional logging has been removed
• Related issues have been referenced in the PR description

Reviewer checklist:

• Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
• Check that tests prove the feature works and covers both happy and unhappy paths
• Check that there aren't other open Pull Requests for the same update/change

[changeset-bot]

⚠️ No Changeset found

Latest commit: 39fb53a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

🟢 No design token changes found

[github-actions]

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

[rezrah]

Based on the feedback you received, we still issue with the stories with custom red outlines:

(sev 3) Within the Custom Class with Aspect Ratio and the Custom Class on Picture examples, the alt attribute has the same placeholder value of "placeholder, blank area with an off-white background color" although a red frame outlines the image.

although a red frame outlines the image.

Can we update the alt text to indicate there's a red outline here please?

Also FYI that the height and width attributes here are still 100%
.

This likely needs a code change under-the-hood for this component. How much effort is that?

[JoshBowdenConcepts]

I discussed the 100% height and width with the a11y eng team and that is ok to keep in there for functionality. I will add the red outline to the description.