Calendar - add option to change step size in yearpicker #15419
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Could you please confirm how this appears on mobile and tablet screens? I'm concerned that the default step size might cause some parts to be cut off. |
| } | ||
|
|
||
| incrementDecade() { | ||
| this.currentYear = this.currentYear + 10; | ||
| incrementYearpickerstep() { |
There was a problem hiding this comment.
same here, incrementYearPickerStep
There was a problem hiding this comment.
I changed it to "incrementYearPickerStep". ("decrement-" and "stepYearpicker" analoge)
I am not sure about the wording. Maybe "incrementYearPicker" (without "-step") would be better? Or maybe "incrementYearPickerRange" or "incrementYearPickerValues"?
|
size 20 on firefox/galaxy s10: size 20 on chrome/galaxy s8 size 10 on firefox/galaxy s10: I feel like these buttons are too small to be comfortable on mobile. But I guess that would be a different issue. |
|
sorry for forcepushing. I squashed some commits, that would add clutter individually. Also I forgot to setup name/mail for git on this machine, and I didn't want "Your Name " and "Your Mail" to pollute the history. |
cetincakiroglu
added
Status: Pending Review
|
Hi, Could you please create an issue and link the PR with the issue? |
|
I can not create an issue (I think?). I can only report bugs. When I click the "feature request" button, I get redirected to the discussion page
|
|
I completely missed the "open a blank issue" button, sorry. I now made the issue, as requested: #15634 |
Hi,
This is my first time contribution. I am not sure about the standard operating procedure. If I made a mistake, please point me in the right direction.
As suggested by the contribution-guidelines, I opened a discussion: https://github.com/orgs/primefaces/discussions/1780
After reading the text in the PR-template (see below), I am no longer certain such a discussion is necessary, since this is a small scale feature.
I think this qualifies as "Smaller scaled feature implementations".
Here is what this PR does:
It changes the default step-size for the year picker from 10 to 20 [1]. And it adds a input-parameter to change the stepsize [2]
In the discussion I explain, why I think this feature is usefull. (But I guess it would be ok to let the discussion-page die, and instead move discussions here)
[1]:
[2]: