Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show 'empty' on dropdown list and empty label on placeholder #15325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elian1780
Copy link
Contributor

@elian1780 elian1780 commented Apr 20, 2024

Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Apr 20, 2024 8:42pm

@rosenthalj
Copy link
Contributor

rosenthalj commented Apr 22, 2024

The changes proposed will most likely break many current developer's code that use the dropdown. I believe (but have not confirmed) this will also break some of the PrimeNG demo examples. Has this change been tested, at a minimum, against all of the the PrimeNG dropdown demos?

Also, as I commented in issue #15308, I do not believe that issue #15308 is a valid bug.

@elian1780
Copy link
Contributor Author

pr on hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants