Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CQI #13742 Step aria-controls showcase #13745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GiacomoDM
Copy link
Contributor

Fix #13742 (doesn't actually fix, it's just for correct liking with the issue)

This PR showcase the usage of the MenuItem's new property overrideAriaControls. This allows to pass the MenuItem the id of the element that the step controls, as shown by the routing example in the Step component doc.

This is just an example and it's difficult to interact with it, because of the previous problems with the Step component that are to be fixed with #13743.

If this solution will be accepted, it will require a porting (or at least an evauation to decide if it's needed) to all other components that uses the MenuItem and have an aria-controls attribute.

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 7:45am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 7:45am

@cetincakiroglu cetincakiroglu added Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Pending Review Issue or pull request is being reviewed by Core Team labels Sep 27, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

New prop added to the menuItem api and not all menu components use MenuItem API can use this new feature. As I see it's specific to steps component, is it possible to find another way to implement it within the scope of the steps component? Because MenuItem API is a common interface and used by various components.

@GiacomoDM
Copy link
Contributor Author

Hi @cetincakiroglu,
I have updated the PR. I extended MenuItem in a new interface StepItem, that only adds the aria property. This way it will always inherit any changes made to the MenuItem and work as expected.
I also updated the docs.

Let me know if this solution is acceptable for you.

@cetincakiroglu
Copy link
Contributor

Hi @GiacomoDM,

Thanks a lot for the effort and support!

Could you please update the PR and resolve the conflicts so we can merge safely?

@cetincakiroglu cetincakiroglu added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility | Step component bugs and improvements
2 participants