72-fix/pivot-table-ui-sum_aggregation-issue #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at help@ellipsis.dev |
ramonverse
requested changes
May 9, 2024
| @@ -239,7 +241,7 @@ export default function PivotTable({ id }: { id: number }) { | |||
| {columns.map((column) => renderColumnBlock(column))} | |||
| </div> | |||
| </div> | |||
| <div className="h-72 overflow-auto"> | |||
| <div className="h-72 overflow-auto" key={JSON.stringify(gridData)}> | |||
There was a problem hiding this comment.
can we use a better key than stringifying gridata? this is not performant at all
There was a problem hiding this comment.
@ramonverse Is it okay to use uuidv4() or should I use a different method?
There was a problem hiding this comment.
keys should be consistent between re-renders. Do a bit of research on this topic and update your PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have solved #72 UI problem showing previous value and sum aggregation issue
Description:
Resolved the UI issue displaying previous values by implementing unique keys that assist React in identifying changes, additions, or removals effectively.
Additionally, addressed the sum aggregation problem by explicitly converting 'value.column' to float.
Pivot_1_solved.mp4