Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add prestissimo/prestissimo-properties.rst #22620

Conversation

steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Apr 26, 2024

Description

Add a page to the Prestissimo Developer Guide index page documentation for configuration properties.

Motivation and Context

Provides a counterpart to Properties Reference for Prestissimo properties.

Impact

Documentation.

Test Plan

Local build of docs.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add Prestissimo Properties Reference page to the Prestissimo Developer Guide documentation :pr:`22620`

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveburnett : Your change looks good.

Though I feel that we should use Presto 2.0 instead of Prestissimo if we have settled on that name.

@tdcmeehan : Maybe we should discuss Presto 2.0 or Prestissimo naming in this weeks Native Worker group meeting ?

@steveburnett
Copy link
Contributor Author

@steveburnett : Your change looks good.

Though I feel that we should use Presto 2.0 instead of Prestissimo if we have settled on that name.

@tdcmeehan : Maybe we should discuss Presto 2.0 or Prestissimo naming in this weeks Native Worker group meeting ?

Thanks @aditi-pandit! If we could, I'd prefer to merge this PR first assuming everything other than "Presto 2.0 or Prestissimo" is good, and then I can immediately open a separate docs PR changing Prestissimo to Presto 2.0 in the existing 3 and this new 4th page.

@tdcmeehan
Copy link
Contributor

My view, which we can discuss in the working group, is that Prestissimo is our project name, and in the end it won't have a separate name but rather a new version (i.e., perhaps a new major version bump in Presto's releases). In my view, we can start to remove references to Prestissimo once we have a plan to make our C++ configuration the default.

@aditi-pandit
Copy link
Contributor

@steveburnett : Your change looks good.
Though I feel that we should use Presto 2.0 instead of Prestissimo if we have settled on that name.
@tdcmeehan : Maybe we should discuss Presto 2.0 or Prestissimo naming in this weeks Native Worker group meeting ?

Thanks @aditi-pandit! If we could, I'd prefer to merge this PR first assuming everything other than "Presto 2.0 or Prestissimo" is good, and then I can immediately open a separate docs PR changing Prestissimo to Presto 2.0 in the existing 3 and this new 4th page.

Thanks @steveburnett. That works.

@steveburnett steveburnett merged commit ea97263 into prestodb:master May 3, 2024
57 checks passed
@steveburnett steveburnett deleted the steveburnett/prestissimo-properties branch May 3, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants