[native] Move static functions from PrestoTask to Util. #22617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitkdutta
changed the title
xiaoxmeng
reviewed
Apr 26, 2024
| @@ -31,4 +31,9 @@ std::shared_ptr<folly::SSLContext> createSSLContext( | |||
| const std::string& clientCertAndKeyPath, | |||
| const std::string& ciphers); | |||
|
|
|||
| /// Returns process-wide CPU time in nanoseconds. | |||
| long getProcessCpuTime(); | |||
There was a problem hiding this comment.
nit: s/getProcessCpuTime/getProcessCpuTimeNs/?
| /// Returns process-wide CPU time in nanoseconds. | ||
| long getProcessCpuTime(); | ||
|
|
||
| std::string taskNumbersToString(const std::array<size_t, 5>& taskNumbers); |
There was a problem hiding this comment.
const std::array<size_t, 5>& taskNumbers
| @@ -220,7 +221,7 @@ proxygen::RequestHandler* TaskResource::createOrUpdateTaskImpl( | |||
| folly::via( | |||
| httpSrvCpuExecutor_, | |||
| [this, &body, taskId, createOrUpdateFunc]() { | |||
| const auto startProcessCpuTime = PrestoTask::getProcessCpuTime(); | |||
| const auto startProcessCpuTime = util::getProcessCpuTime(); | |||
There was a problem hiding this comment.
NYC: s/startProcessCpuTime/startProcessCpuTimeNs/
| @@ -775,27 +763,6 @@ void PrestoTask::updateExecutionInfoLocked( | |||
| prestoTaskStats); | |||
| } | |||
|
|
|||
| /*static*/ std::string PrestoTask::taskNumbersToString( | |||
There was a problem hiding this comment.
We might want to keep this as static method of PrestoTask as the states are specific to PrestoTask internal
s/taskNumbersToString/taskStatesToString/
mbasmanova
reviewed
Apr 26, 2024
| @@ -31,4 +31,9 @@ std::shared_ptr<folly::SSLContext> createSSLContext( | |||
| const std::string& clientCertAndKeyPath, | |||
| const std::string& ciphers); | |||
|
|
|||
| /// Returns process-wide CPU time in nanoseconds. | |||
There was a problem hiding this comment.
It would be nice to avoid files / classes named Util as they tend to become a "dumping ground" for lots of unrelated code. It would be better to come with more specific names.
|
Closing this in favor of #22662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor refactor to move static tasks from PrestoTask struct to Util.
Motivation and Context
We are trying to make PrestoTask a class instead of a struct for better encapsulation. Moving static methods out of the struct makes this easier. Besides the functions we are moving aren't a good fit for PrestoTask.
Impact
No impact.
Test Plan
Existing unit tests