New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add row ID support to batch ORC reader #22615
Conversation
18e37fa
to
623481c
Compare
ee5d947
to
52918b2
Compare
34c6fdd
to
e11fa04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Might want to add more tests.
Can we add some unit tests ? |
There are 5 checkstyle errors. please check.
|
aaabd3a
to
9f6f82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL. Adding unit tests invalidated existing approvals.
The test added in this PR is failing . please check
|
Fixed. Unfortunately that invalidates existing approvals. :-( |
Remaining failure looks flaky, rerunning |
Description
Previously only done in selective reader
Motivation and Context
Fill in row IDs on more paths
Impact
none
Test Plan
CI
Contributor checklist
Release Notes