Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect nullability reporting in Presto JDBC metadata #22612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srameshkanna
Copy link

@srameshkanna srameshkanna commented Apr 25, 2024

Description

While inspecting columns to identify which ones support null values and which ones do not . presto unable to distinguish between them due to hardcoded metadata for all column.so added fix for that.

Motivation and Context

Issue: #11510

Impact

Incorrect Hive table column nullability reporting by the Presto JDBC driver led to inconsistent schema handling and query planning .

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ...
* ...

Hive Connector Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

@srameshkanna srameshkanna requested a review from a team as a code owner April 25, 2024 10:50
Copy link

linux-foundation-easycla bot commented Apr 25, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@tdcmeehan tdcmeehan self-assigned this Apr 25, 2024
Copy link
Contributor

@ClarenceThreepwood ClarenceThreepwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants