Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correctness issue in regr_r2 #22611

Merged
merged 1 commit into from Apr 29, 2024
Merged

Fix correctness issue in regr_r2 #22611

merged 1 commit into from Apr 29, 2024

Conversation

8dukongjian
Copy link
Contributor

Description

Fix regr_r2 result incorrect. There are two special cases:

  1. m2X() = 0, then result should be NULL
  2. m2X() != 0 and m2Y() = 0, then result shoule be 1.

Found by facebookincubator/velox#9522

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Fix regr_r2 result incorrect.

Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@8dukongjian Thank you for the fix.

CC @tdcmeehan

Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@8dukongjian Would you update comment message to follow the guidelines?

There are two special cases:
1. m2X() = 0, then result should be NULL
2. m2X() != 0 and m2Y() = 0, then result shoule be 1.
@8dukongjian
Copy link
Contributor Author

@8dukongjian Would you update comment message to follow the guidelines?

Thanks, updated.

Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@8dukongjian Thank you for adding details to the commit message. There is some broken English in the title. Would you update as well? Thanks.

Fix regr_r2 result incorrect

Fix correctness issue in regr_r2

@mbasmanova mbasmanova changed the title Fix regr_r2 result incorrect Fix correctness issue in regr_r2 Apr 26, 2024
@mbasmanova
Copy link
Contributor

CC: @steveburnett

@steveburnett
Copy link
Contributor

Maybe the following changes to the release note entry:

== RELEASE NOTES ==

General Changes
* Fix correctness issue in regr_r2 :pr:`22611`

@mbasmanova, is there anything else I can help with here?

@mbasmanova
Copy link
Contributor

@8dukongjian Please, help fix commit message here: https://github.com/prestodb/presto/pull/22611/commits

@mbasmanova
Copy link
Contributor

@steveburnett Steve, thank you for looking. Wanted to FYI you because this is a user-visible change in behavior and requires an RN.

Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @8dukongjian. @wanglinsong can we add this to 0.287?

@tdcmeehan tdcmeehan merged commit 4bd198a into prestodb:master Apr 29, 2024
56 checks passed
@8dukongjian
Copy link
Contributor Author

@8dukongjian Thank you for adding details to the commit message. There is some broken English in the title. Would you update as well? Thanks.

Fix regr_r2 result incorrect

Fix correctness issue in regr_r2

@mbasmanova

Thank you for your comments. Sorry, I was too busy recently and forgot to fix it.

@wanglinsong
Copy link
Member

Thanks for the fix @8dukongjian. @wanglinsong can we add this to 0.287?

I cherry-picked it into the release-0.287 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants