New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support procedure expire_snapshots for iceberg #22609
Merged
hantangwangd
merged 2 commits into
prestodb:master
from
hantangwangd:support_expire_snapshots
May 7, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
...iceberg/src/main/java/com/facebook/presto/iceberg/procedure/ExpireSnapshotsProcedure.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.iceberg.procedure; | ||
|
|
||
| import com.facebook.presto.common.type.SqlTimestamp; | ||
| import com.facebook.presto.iceberg.IcebergAbstractMetadata; | ||
| import com.facebook.presto.iceberg.IcebergMetadataFactory; | ||
| import com.facebook.presto.iceberg.IcebergUtil; | ||
| import com.facebook.presto.spi.ConnectorSession; | ||
| import com.facebook.presto.spi.SchemaTableName; | ||
| import com.facebook.presto.spi.classloader.ThreadContextClassLoader; | ||
| import com.facebook.presto.spi.procedure.Procedure; | ||
| import com.google.common.collect.ImmutableList; | ||
| import org.apache.iceberg.ExpireSnapshots; | ||
| import org.apache.iceberg.Table; | ||
|
|
||
| import javax.inject.Inject; | ||
| import javax.inject.Provider; | ||
|
|
||
| import java.lang.invoke.MethodHandle; | ||
| import java.util.List; | ||
|
|
||
| import static com.facebook.presto.common.block.MethodHandleUtil.methodHandle; | ||
| import static com.facebook.presto.common.type.StandardTypes.INTEGER; | ||
| import static com.facebook.presto.common.type.StandardTypes.TIMESTAMP; | ||
| import static com.facebook.presto.common.type.StandardTypes.VARCHAR; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class ExpireSnapshotsProcedure | ||
| implements Provider<Procedure> | ||
| { | ||
| private static final MethodHandle EXPIRE_SNAPSHOTS = methodHandle( | ||
| ExpireSnapshotsProcedure.class, | ||
| "expireSnapshots", | ||
| ConnectorSession.class, | ||
| String.class, | ||
| String.class, | ||
| SqlTimestamp.class, | ||
| Integer.class, | ||
| List.class); | ||
| private final IcebergMetadataFactory metadataFactory; | ||
|
|
||
| @Inject | ||
| public ExpireSnapshotsProcedure(IcebergMetadataFactory metadataFactory) | ||
| { | ||
| this.metadataFactory = requireNonNull(metadataFactory, "metadataFactory is null"); | ||
| } | ||
|
|
||
| @Override | ||
| public Procedure get() | ||
| { | ||
| return new Procedure( | ||
| "system", | ||
| "expire_snapshots", | ||
| ImmutableList.of( | ||
| new Procedure.Argument("schema", VARCHAR), | ||
| new Procedure.Argument("table_name", VARCHAR), | ||
| new Procedure.Argument("older_than", TIMESTAMP, false, null), | ||
| new Procedure.Argument("retain_last", INTEGER, false, null), | ||
| new Procedure.Argument("snapshot_ids", "array(bigint)", false, null)), | ||
| EXPIRE_SNAPSHOTS.bindTo(this)); | ||
| } | ||
|
|
||
| public void expireSnapshots(ConnectorSession clientSession, String schema, String tableName, SqlTimestamp olderThan, Integer retainLast, List<Long> snapshotIds) | ||
| { | ||
| try (ThreadContextClassLoader ignored = new ThreadContextClassLoader(getClass().getClassLoader())) { | ||
| doExpireSnapshots(clientSession, schema, tableName, olderThan, retainLast, snapshotIds); | ||
| } | ||
| } | ||
|
|
||
| private void doExpireSnapshots(ConnectorSession clientSession, String schema, String tableName, SqlTimestamp olderThan, Integer retainLast, List<Long> snapshotIds) | ||
| { | ||
| IcebergAbstractMetadata metadata = (IcebergAbstractMetadata) metadataFactory.create(); | ||
| SchemaTableName schemaTableName = new SchemaTableName(schema, tableName); | ||
| Table icebergTable = IcebergUtil.getIcebergTable(metadata, clientSession, schemaTableName); | ||
|
|
||
| ExpireSnapshots expireSnapshots = icebergTable.expireSnapshots(); | ||
|
|
||
| if (snapshotIds != null) { | ||
| for (long id : snapshotIds) { | ||
| expireSnapshots = expireSnapshots.expireSnapshotId(id); | ||
| } | ||
| } | ||
|
|
||
| if (olderThan != null) { | ||
| expireSnapshots = expireSnapshots.expireOlderThan(olderThan.isLegacyTimestamp() ? olderThan.getMillisUtc() : olderThan.getMillis()); | ||
| } | ||
|
|
||
| if (retainLast != null) { | ||
| expireSnapshots = expireSnapshots.retainLast(retainLast); | ||
| } | ||
|
|
||
| expireSnapshots.cleanExpiredFiles(true) | ||
| .commit(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a word missing after "array of long"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, what I want to express is that the type is
array of long. Is it OK with this expression in your opinion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine! I was unfamiliar with the phrase and I should have looked it up first. This is good as is. Thanks!