[native] Improve Zombie Tasks logging. #22607
Conversation
|
|
||
| ZombieTaskStats( | ||
| const std::shared_ptr<exec::Task>& task, | ||
| long numExtraReferences_) |
There was a problem hiding this comment.
Comment say the extra references could be either from velox or presto? Thanks!
There was a problem hiding this comment.
This is conveyed on another level.
The structure has no knowledge about it.
| const std::string info; | ||
| const long numExtraReferences; | ||
|
|
||
| ZombieTaskStats( |
There was a problem hiding this comment.
Nit: Why was explicit removed? This should still be used for the construction during the emplace call like before?
There was a problem hiding this comment.
explicit is was used for single-argument constructors, so there would be no implicit type conversion.
1. Only get task info is really needed. 2. Log also the number of extra references. 3. Log the type of Task for each task.
spershin
force-pushed
the
ImproveZombieTaskLogging
branch
from
1b42782
to
756ec4f
Compare
|
|
||
| ZombieTaskStats( | ||
| const std::shared_ptr<exec::Task>& task, | ||
| long _numExtraReferences) |
There was a problem hiding this comment.
s/long/uint32_t/ why long? Thanks!
There was a problem hiding this comment.
@xiaoxmeng
Simply based on where we get them from:
const auto prestoTaskRefCount = prestoTask.use_count();
which comes from
long use_count() const _NOEXCEPT
Description
If release note is NOT required, use: