Make constructor package protected

[elharo]

Description

remove public modifier from constructor of non public class

Motivation and Context

A little easier to understand and reason about the code

Impact

none

Test Plan

ci

Contributor checklist

• Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

== NO RELEASE NOTE ==

[tdcmeehan]

@elharo practically, what does this change do? If the class itself is package protected, does it make much of a difference that the constructor is public?

[elharo]

It's a minor clarification. The public modifier has no effect here. Why include additional verbiage that's a no-op? It's unfortunate that IDEs tend to generate code that makes methods public by default.