Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error_prone_annotations to 2.3.4 #22583

Merged
merged 1 commit into from Apr 29, 2024
Merged

Update error_prone_annotations to 2.3.4 #22583

merged 1 commit into from Apr 29, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Apr 22, 2024

Description

Add dependency_management to update old dependency pulled in via cassandra project

Motivation and Context

Unblocking Guava upgrade

Impact

none

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@elharo elharo requested a review from tdcmeehan April 22, 2024 18:07
@elharo elharo marked this pull request as ready for review April 22, 2024 18:16
@elharo elharo requested a review from a team as a code owner April 22, 2024 18:16
@elharo elharo requested a review from presto-oss April 22, 2024 18:16
@@ -14,6 +14,16 @@
<properties>
<air.main.basedir>${project.parent.basedir}</air.main.basedir>
</properties>

<dependencyManagement>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks off--looks like indented with tabs instead of spaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now

@steveburnett
Copy link
Contributor

Consider adding a release note entry, like

== RELEASE NOTES ==

Security Changes
* Upgrade error_prone_annotations to 2.3.4 :pr:`22583`

@tdcmeehan
Copy link
Contributor

@steveburnett I don't think that's necessary, since it's a build related upgrade and doesn't have any user-facing functionality differences.

@elharo
Copy link
Contributor Author

elharo commented Apr 29, 2024

Agreed. This is not itself a security fix. It's just one step along the way to upgrading the thing we actually care about.

@elharo elharo merged commit 1d27c73 into master Apr 29, 2024
56 checks passed
@elharo elharo deleted the cass branch April 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants