Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether Guava 30.0-jre works #22572

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Check whether Guava 30.0-jre works #22572

wants to merge 2 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Apr 19, 2024

not for merge, let's just see if this breaks anything

@elharo
Copy link
Contributor Author

elharo commented Apr 22, 2024

2024-04-22T14:02:29.0185479Z Failed while enforcing RequireUpperBoundDeps. The error(s) are [
2024-04-22T14:02:29.0187073Z Require upper bound dependencies error for com.google.errorprone:error_prone_annotations:2.1.3 paths to dependency are:
2024-04-22T14:02:29.0188711Z +-com.facebook.presto:presto-cassandra:0.288-SNAPSHOT
2024-04-22T14:02:29.0189819Z   +-com.facebook.presto.cassandra:cassandra-driver:3.6.0-1
2024-04-22T14:02:29.0190877Z     +-com.google.errorprone:error_prone_annotations:2.1.3
2024-04-22T14:02:29.0191680Z and
2024-04-22T14:02:29.0192883Z +-com.facebook.presto:presto-cassandra:0.288-SNAPSHOT
2024-04-22T14:02:29.0193866Z   +-com.google.guava:guava:30.0-jre
2024-04-22T14:02:29.0194806Z     +-com.google.errorprone:error_prone_annotations:2.3.4
2024-04-22T14:02:29.0195617Z , 
2024-04-22T14:02:29.0196857Z Require upper bound dependencies error for com.google.j2objc:j2objc-annotations:1.1 paths to dependency are:
2024-04-22T14:02:29.0198371Z +-com.facebook.presto:presto-cassandra:0.288-SNAPSHOT
2024-04-22T14:02:29.0199493Z   +-com.facebook.presto.cassandra:cassandra-driver:3.6.0-1
2024-04-22T14:02:29.0200548Z     +-com.google.j2objc:j2objc-annotations:1.1
2024-04-22T14:02:29.0201296Z and
2024-04-22T14:02:29.0202012Z +-com.facebook.presto:presto-cassandra:0.288-SNAPSHOT
2024-04-22T14:02:29.0202939Z   +-com.google.guava:guava:30.0-jre
2024-04-22T14:02:29.0203798Z     +-com.google.j2objc:j2objc-annotations:1.3
2024-04-22T14:02:29.0204506Z and
2024-04-22T14:02:29.0205190Z +-com.facebook.presto:presto-cassandra:0.288-SNAPSHOT
2024-04-22T14:02:29.0206200Z   +-com.facebook.presto:presto-main:0.288-SNAPSHOT
2024-04-22T14:02:29.0207207Z     +-com.facebook.presto:presto-client:0.288-SNAPSHOT
2024-04-22T14:02:29.0208273Z       +-com.google.auth:google-auth-library-oauth2-http:0.12.0
2024-04-22T14:02:29.0209662Z         +-com.google.http-client:google-http-client:1.27.0
2024-04-22T14:02:29.0210835Z           +-com.google.j2objc:j2objc-annotations:1.1

@elharo
Copy link
Contributor Author

elharo commented Apr 29, 2024

Next up:

2024-04-29T15:07:35.5818102Z Failed while enforcing RequireUpperBoundDeps. The error(s) are [
2024-04-29T15:07:35.5819942Z Require upper bound dependencies error for com.google.j2objc:j2objc-annotations:1.1 paths to dependency are:
2024-04-29T15:07:35.5821352Z +-com.facebook.presto:presto-cassandra:0.288-SNAPSHOT
2024-04-29T15:07:35.5822283Z   +-com.facebook.presto.cassandra:cassandra-driver:3.6.0-1
2024-04-29T15:07:35.5823152Z     +-com.google.j2objc:j2objc-annotations:1.1
2024-04-29T15:07:35.5824157Z and
2024-04-29T15:07:35.5824721Z +-com.facebook.presto:presto-cassandra:0.288-SNAPSHOT
2024-04-29T15:07:35.5825491Z   +-com.google.guava:guava:30.0-jre
2024-04-29T15:07:35.5826343Z     +-com.google.j2objc:j2objc-annotations:1.3
2024-04-29T15:07:35.5826904Z and
2024-04-29T15:07:35.5827455Z +-com.facebook.presto:presto-cassandra:0.288-SNAPSHOT
2024-04-29T15:07:35.5828279Z   +-com.facebook.presto:presto-main:0.288-SNAPSHOT
2024-04-29T15:07:35.5829087Z     +-com.facebook.presto:presto-client:0.288-SNAPSHOT
2024-04-29T15:07:35.5829992Z       +-com.google.auth:google-auth-library-oauth2-http:0.12.0
2024-04-29T15:07:35.5830908Z         +-com.google.http-client:google-http-client:1.27.0
2024-04-29T15:07:35.5831718Z           +-com.google.j2objc:j2objc-annotations:1.1
2024-04-29T15:07:35.5832319Z ]

@elharo elharo mentioned this pull request Apr 30, 2024
6 tasks
@elharo
Copy link
Contributor Author

elharo commented May 1, 2024

Looks like Guava 27 removed SettableFuture.transform:

2024-05-01T19:49:31.6555047Z [ERROR] /home/runner/work/presto/presto/presto-hive/src/main/java/com/facebook/presto/hive/HiveSplitSource.java:[331,50] cannot find symbol
2024-05-01T19:49:31.6556967Z symbol: method transform((ignored)-[...].of(),java.util.concurrent.Executor)
2024-05-01T19:49:31.6557755Z location: variable allSplitLoaded of type com.google.common.util.concurrent.SettableFuture<?>
2024-05-01T19:49:31.6558337Z [INFO] 1 error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant