Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod] Remove unused variables in github/presto-trunk/presto-native-execution/presto_cpp/main/tests/TaskManagerTest.cpp #22569

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[codemod] Remove unused variables in github/presto-trunk/presto-native-execution/presto_cpp/main/tests/TaskManagerTest.cpp #22569

wants to merge 1 commit into from

Commits on Apr 19, 2024

  1. [codemod] Remove unused variables in github/presto-trunk/presto-nativ… 

    …e-execution/presto_cpp/main/tests/TaskManagerTest.cpp (prestodb#22569)

Summary:

LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D56067459
    @r-barnes @facebook-github-bot
    r-barnes authored and facebook-github-bot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f67f368 View commit details
    Browse the repository at this point in the history