Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split long array literals to use concat #21601

Open
kaikalur opened this issue Dec 24, 2023 · 2 comments · May be fixed by #22622
Open

Split long array literals to use concat #21601

kaikalur opened this issue Dec 24, 2023 · 2 comments · May be fixed by #22622
Labels
beginner-task bootcamp Query Optimization

Comments

@kaikalur
Copy link
Contributor

An occasional issue in presto is with users trying to create arrays with more than 200 elements. Since we can count the cardinality during analysis, simply split and concat it to make life easy for users. So when a user writes:

ARRAY[1,2,3..1000]

We can split it into:

ARRAY[1,2,..200] || ARRAY [201,...400] || ARRAY[.. ]

during the plan/RowExpression generation and it should work.
@TishyaaChaudhry
Copy link
Contributor

Can I also try working on this if it's still open? Thanks

@kaikalur
Copy link
Contributor Author

kaikalur commented Apr 9, 2024

Can I also try working on this if it's still open? Thanks

Sure go for it! It's not fixed AFAIK.

@AlinaFang1123 AlinaFang1123 mentioned this issue Apr 27, 2024
Open
@arararz arararz linked a pull request Apr 28, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-task bootcamp Query Optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement large array constructing through chunk concatenation TishyaaChaudhry/presto-cute-capybaras
2 participants
@kaikalur @TishyaaChaudhry