Skip to content

Commit

Permalink
[codemod] Remove unused variables in github/presto-trunk/presto-nativ…
Browse files Browse the repository at this point in the history
…e-execution/presto_cpp/main/tests/TaskManagerTest.cpp

Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D56067459
  • Loading branch information
r-barnes authored and facebook-github-bot committed Apr 19, 2024
1 parent d2b2ae9 commit e8556db
Showing 1 changed file with 0 additions and 2 deletions.
Expand Up @@ -158,8 +158,6 @@ void setAggregationSpillConfig(
queryConfigs.emplace(core::QueryConfig::kAggregationSpillEnabled, "true");
}

static const uint64_t kGB = 1024 * 1024 * 1024ULL;

class TaskManagerTest : public testing::Test {
public:
static void SetUpTestCase() {
Expand Down

0 comments on commit e8556db

Please sign in to comment.