Better port in use information #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
suggested changes
Feb 2, 2018
|
@kokosing Yeah I will check later when I have time |
findepi
reviewed
Feb 2, 2018
| "server start...") | ||
| error('Server failed to start on %s. Port %s already in use' | ||
| % (env.host, str(portnum))) | ||
| if 'command not found' in output: |
There was a problem hiding this comment.
if we set -o pipefail in run(str), we should exercise better control... Or, perhaps, netstat should be run as command and grep as Py-level processing. (with set -o pipefail there is this problem with grep that it reports failure when no line matched, so you'd need | { grep ... || true }...)
@kokosing what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.