Improve handling of delimiters with backslashes #403
Conversation
|
Just wanted to add that the definition for troff/mandoc probably should be Also this pr doesn't actually fix the issue with groff |
|
Thanks for the report and the attempt to fix ti @roryrjb. I'm not entirely sure myself how this should be fixed. Also I won't have time to dig into it for at least a few days. As I understand it this PR currently fixes troff but not groff right? Also I would suggest going ahead and adding a commit to this PR that changes the default delimiter for troff/mandoc if you think you can make the case for the default change being for the best. |
|
@alerque that's correct, this only fixes troff but I'm going to see if I can fix groff too. I'll also see if changing the delimiters for troff and mandoc will improve things, because I think that will make them closer to groff and all can be fixed in the same way. |
|
What's the status on this @roryrjb? Let me know when I should give this another review. Sorry I wasn't very available back when it came in, if you need something let me know. |
|
@alerque hey, I haven't had much time but still want to crack this, especially as I'm working with troff this weekend. I'm hoping to have a fix very soon, will let you know. Hope you had a good Christmas and all the best for 2020! |
This pull request has been opened to address issue #402 I raised separately.
As mentioned in the issue description, I recently added delimiter definitions for troff family languages, which included, for the first time backslashes:
...but these aren't handled correctly in some cases. Currently the plugin can add them but they won't be detected when trying to remove them, so they get added again.
This pull request is trying to solve this, although it might not be in the best way and others may have a better solution to this, but of course if I can contribute then I'll try to.