Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check on file exist for xhprof_urlSimilartor_include #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StVolodymyr
Copy link

No description provided.

@preinheimer
Copy link
Owner

So the goal here is to avoid having a fatal error if there's a specified value, but the path fails?

I'm quite torn. I'd really rather things failed loudly, rather than silently (imagine specifying the wrong path, expecting it to have worked, and getting nothing). But non-fatal errors are also super.

thoughts?

@StVolodymyr
Copy link
Author

i don't want get fatal error when file not exists, because it crash whole application. though, you're right what silently ignore this error is not good.
I think what warning trigger_error("File urlSimilartor {$similartorinclude} not exist", E_USER_WARNING) is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants